[PEPr] +1 for Text::Text_Bayes
| From: | Mark Wiesemann | Date: | Mon, 14 Aug 2006 20:50:40 +0000 |
| Subject: | [PEPr] +1 for Text::Text_Bayes | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-43693@lists.php.net to get a copy of this message | ||
Mark Wiesemann (http://pear.php.net/user/wiesemann) has voted +1 on the proposal for
Text::Text_Bayes.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=431
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=431&handle=wiesemann
Comment:
If it makes sense in your opinion, you might want to use phpDocumentor
compatible comments for the constants to get API docs for them:
// Indicates text type ham
define("TEXT_BAYES_POSITIVE", 1001);
(Justin might also add that you should use single quotes [not only here])
Some CS issues:
- no space before the '(':
public function __construct ($storage_module, $storage_configuration) //
no space before the '('
- wired indentation, e.g. here:
case TEXT_BAYES_POSITIVE:
$token['positive_count'] =
(int)$token['positive_count'] + 1;
break;
- missing spaces:
for ($i=1;$i<=floor($freedom / 2);$i++) {
Apart from these minor issues: a very nice package!
--
Sent by PEPr, the automatic proposal system at http://pear.php.net