Re: Re: cvs: pear /MDB2/tests MDB2_usage_testcase.php

On 8/20/06, Lukas Kahwe Smith <lsmith@php.net> wrote:

Daniel Convissor wrote: Hi Lukas: On Sun, Aug 20, 2006 at 08:06:14PM +0200, Lukas Kahwe Smith wrote:

Not sure I understand what you are saying.

...

RDBMS xyz does not automatically RTRIM data coming from a CHAR field.

I'm proposing (additional ?) tests that run under MDB2_PORTABILITY_NONE. The test would be something like this for the test you used above: switch mysql:

      $expected = 'some string';

mssql:

      $expected = 'some string      ';

if ($actual == $expected) echo great else echo oops My proposal is in response to what I thought your initial question was in this thread. Perhaps I misunderstood. If so, tests like this might be a good thing anyway. All that aside, this is just a suggestion. Ah ok. I am beginning to understand. Since obviously some people might rely on how a given driver behaves if the portability features are disabled, that this is also tested. Fair enough. Something that should indeed be covered.

That makes sense. Sorry for just unilaterally disabling the test but I figured it would spark a discussion here and it did. ;-) After reading this thread it seems like it might be a good idea to take these tests and move them to a different test "module" which says somewhere that it may fail differently for different RDBMS. The above idea to test for RDBMS specific stuff like Oracle always returning CAPS fields mught also be nice but it would, of course, be an RDBMS specific test. -- Justin Patrin