Re: Console_Table improvements

Zitat von Laurent Laville <pear@laurent-laville.org>:

Hi Console_Table maintainers, Since i've tried to implement a solution to limit PHP_CompatInfo_Cli output to 80 columns, i've run lot of tests on your package. Even if i don't know it as one of mine, i've noticed :

    function _splitMultilineRows() {

that should be written (if PEAR CS is applied)

    function _splitMultilineRows()
    {

Yes, i know i'm nitpicking ;-)

Fixed in CVS.

But also, while i implement my filter callback what use intensive PHP strlen() function, i've noticed your "private" method _strlen(). Perharps it could be interresting to make it public for reuse ?

I'm not sure if this is a good idea. While code reuse is fine, it doesn't make sense to use the Console_Table package if you need a multibyte safe strlen() implementation. For a separate package, it's too few code. I guess it's one of the edge case where copy and pasting code makes more sense than code reuse. Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting/