[PEPr] Comment on Structures::Structures_Linked_List

Scott Mattocks (http://pear.php.net/user/scottmattocks) has commented on the proposal for Structures::Structures_Linked_List. Comment: Why put a singleton errorstack instance into the GLOBALS array? You can get to that instance at any time using the singleton method. Don't use double quotes unless you have to. (I don't see anywhere that you have to) I think the API would be cleaner and easier to use if instead of: addNode($newNode, $mode, $oldNode) you had: prependNode($node) appendNode($node) insertNode($newNode, $oldNode, $before = false) I don't see the much value in: $retval = false; return $retval; Just return false instead of wasting an operation assigning it to something else first. The package should be named Structures_LinkedList with the classes named Structures_LinkedList and Structures_LinkedList_Node. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=444 -- Sent by PEPr, the automatic proposal system at http://pear.php.net