Re: [Patch] DB_DataObject and Postgres INSERT race conditionobtaininglast key

Sure, Alan, I can take care of it. Matt Alan Knowles wrote: > Matt, do you want to look after that. > Regards > Alan > Lukas Kahwe Smith wrote: > >>Alan Knowles wrote: >> >> >>>>Anyways if you do the following you should already get this >>>>information: >>>>$mdb2->reverse->tableInfo($table_name); >>> >>>Yes, they point was to put the code to extract that into MDB/postgres >>>driver, rather than weighing down the more generic layers. >>>Something like >>>pgsql.php / override getSequenceName >>> >>>function getSequenceName($sqn, $col = false) >>>{ >>> if ($col == false) { >>> return parent::getSequenceName($sqn); >>> } >>> $ti = $this->reverse->tableInfo($sqn); >>> ... grab the col & parse the nextval(); >>>} >> >>Yeah that would be doable. >>tableInfo() is kinda heavy though, since it calls >>getTableFieldDefinition() for every column. Someone should probably >>add a method that gets all the column definitions in a single query. >> >>But that is another story. Could you file this as a feature request? >> >>regards, >>Lukas >> > >