[PEPr] Comment on Web Services::Services_W3C_HTMLValidator
| From: | Mark Wiesemann | Date: | Mon, 04 Dec 2006 18:31:57 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_W3C_HTMLValidator | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-45092@lists.php.net to get a copy of this message | ||
Mark Wiesemann (http://pear.php.net/user/wiesemann) has commented on the proposal for Web
Services::Services_W3C_HTMLValidator.
Comment:
Two comments on the following lines of code:
switch ($type) {
case 'uri':
default:
$this->_request->setMethod(HTTP_REQUEST_METHOD_GET);
$this->_request->addQueryString('uri', $this->uri);
$method = 'addQueryString';
break;
- "break" should be indented the same as the three lines above of it
- having the "default" case here seems to circumvent that the script
reaches the other cases (below the default case)
And to be nit-picky:
"$var=>$val" in Message.php should get two spaces
Apart from these issues: Nice idea, nice package.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=461
--
Sent by PEPr, the automatic proposal system at http://pear.php.net