[PEPr] Comment on Encryption::Crypt_DSA
| From: | Jim Wigginton | Date: | Fri, 22 Dec 2006 18:59:06 +0000 |
| Subject: | [PEPr] Comment on Encryption::Crypt_DSA | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-45329@lists.php.net to get a copy of this message | ||
Jim Wigginton (http://pear.php.net/user/terrafrost) has commented on the proposal for
Encryption::Crypt_DSA.
Comment:
From your code:
$s1 = self::_bindec(base64_decode($r_sig));
Might the following be better?:
$s1 = new Math_BigInteger(base64_decode($r_sig), 256);
Otherwise looks good!
Also, if you could maybe confirm that the fix I proposed in your bug
report for Math_BigInteger works, I'd be appreciative - thanks :)
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=467
--
Sent by PEPr, the automatic proposal system at http://pear.php.net