Re: PEARifying Doctrine

Lukas Kahwe Smith wrote: > Hi, > > So I am starting on PEARifying Doctrine. This should give me a good > opportunity to learn the source code more in depth as I fix minor > formating issues. The file structure is already quite in line with our > CS, so I do not envision the need for drastic changes. I will try to use > PHP_CodeSniffer here, though due to the lack of documentation and > examples I will first have to poke through the tests I guess. > > The idea is to split things into packages as follows: > > Doctrine DBAL core > - sub packages for all drivers > - sub package for ORM core > - sub packages for Util, DQL etc. > > Currently Doctrine uses SimpleTest, which is not E_STRICT so we might > also migrate to PHPUnit3. Hi, This is great, Lukas. On this last point, I hardly think it is worth migrating unit tests to make the testing environment E_STRICT. It should be relatively simple to create a custom error handler to filter out errors originating inside SimpleTest. Of course, if you are going to migrate, I would prefer .phpt but who listen to me on this point :) Incidentally, I would also be interested in having Doctrine as one of the first PEAR2 packages. This would NOT affect its ability to be installed via the older installer, but instead would allow it to take advantage of the new design features that are planned. It's no longer complete vaporware, I had LOTS of time at the in-laws over holidays :). Details and commits of the first proof-of-concept installer files will be coming very soon. Thanks, Greg