Re: New Proposal Draft - Log_xml - Need advice about 'links' section

Hi Michael, Michael Gower wrote: > I have a new package, Log_xml, and am unsure how the 'links' part of PEPr > works. I have my entire source code hosted at code.google.com with > subversion but there isn't a 'svn' option for the links. Should I list > every php file individually (as phps)? (IMHO:) It's fine the way you did it. No need for linking every file, as such links are only click away. > Also according to the 'New Mainters Guide' I should be initiating a > discussion about the package, I hope this does it. You could have also switched to "Proposal" stage instead of writing to the list. This would have triggered an automated email to the pear-dev list and people could comment on it via the comments form. > Feel free to take a look (it's up to PEAR coding standards, etc). There are some spacing issues like "if( !$creating" or "if (isset( $conf['schema'] )) {". But the most important question is: Have you contacted Jon Parise, the maintainer of the Log package. If you don't insist of having your own Log_XML package, he might want to include your driver into his package. Regards, Mark