[PEPr] Comment on Authentication::Auth_WiKID
| From: | Greg Beaver | Date: | Thu, 15 Mar 2007 03:14:29 +0000 |
| Subject: | [PEPr] Comment on Authentication::Auth_WiKID | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-45915@lists.php.net to get a copy of this message | ||
Greg Beaver (http://pear.php.net/user/cellog) has commented on the proposal for
Authentication::Auth_WiKID.
Comment:
Thanks Greg.
A few comments:
1) there seems to be a problem with the generated documentation, only the
class docs are available. This is FYI, I can understand it isn't needed
if you have the .phps
2) The PEAR manual at pear.php.net is egregiously out of date. All new
submissions to PEAR must be E_STRICT compliant. This means you must
depend on PHP 5.0.0 or newer, and can't use PEAR_Error, or PEAR. Instead,
use PEAR_Exception. Relevant documentation is at
http://pear.php.net/pepr/pepr-proposal-show.php?id=419
(It's not your
fault you didn't know this, I just spent 10 minutes trying to find it in
the manual and failed).
Your coding style is very clean and easy to read.
You need to add a dependency on the openssl extension to the list of
dependencies and to package.xml on release.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=321
--
Sent by PEPr, the automatic proposal system at http://pear.php.net