Re: Proposal Auth_WIKID Extra Comment (QA)

David Coallier wrote: > Hello all, this is an email to do extra QA on > http://pear.php.net/pepr/pepr-proposal-show.php?id=321 > > First of all Greg, good work on the package, I really like the overall > structure, the code is very clean, and I like the comments themselves > and it looks good. > > However, I must add a couple points: > > The package is noted as PHP5, so the variable properties should be > respected. I see in the documentor's code that all the variables > access is noted as @access private, therefore, you should usually make > the variables > private $_isConnected instead of var $_isConnected; Because by > default var is now E_STRICT compliant, however it will make the > variables public. > > Also, making the variables private is not recommended as it makes them > less flexible, therefore it is recommended to use * protected for pear > packages. I would add that this advice does not make much sense. I mean that one should use private and protected when necessary, there are very good reasons to have a private property and not wanting any derived class using it. So the advice should be to use what makes sense in the design of the class and should be left to the developer to decide. ps: no offense david :) Arnaud.