[PEPr] Comment on PHP::Debug

From: Date: Thu, 12 Apr 2007 10:24:45 +0000
Subject: [PEPr] Comment on PHP::Debug
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-46202@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for PHP::Debug. Comment: Nice idea. Here are a few comments: - __toString needs an uppercase S - Please put every class in an own file, e.g. PHP_Debug_Line - Only use private if really needed. Protected methods/variables can be used from inheriting classes. - Do not use global constants but class constants. This avoids cluttering global namespace - "class PHP_Debug_Renderer_HTML_Div_Config" is in the wrong file. PEAR CS tell you that underscores need to be replaced with slashes, while you put it into PHP/Debug/Renderer/HTML_Div_Config.php - If you use visiblity modifiers (public, protected, private), use them everywhere - "@since 30 march 2007" normally tells you which version, not which date Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=260 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#46202) next »