Re : [PEPr] Comment on PHP::Debug

Ok Christan thanks, For the class name that means that i must change PHP_Debug_Line to PHP_DebugLine and same for other classes witch are not supposed to be in a sub directory. ----- Message d'origine ---- De : Christian Weiske <cweiske@php.net> À : PEAR developer mailinglist <pear-dev@lists.php.net> Cc : Christian Weiske <cweiske@php.net>; Loïc Vernet <qrf_coil@yahoo.fr> Envoyé le : Jeudi, 12 Avril 2007, 12h24mn 45s Objet : [PEPr] Comment on PHP::Debug Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for PHP::Debug.. Comment: Nice idea. Here are a few comments: - __toString needs an uppercase S - Please put every class in an own file, e.g. PHP_Debug_Line - Only use private if really needed. Protected methods/variables can be used from inheriting classes. - Do not use global constants but class constants. This avoids cluttering global namespace - "class PHP_Debug_Renderer_HTML_Div_Config" is in the wrong file. PEAR CS tell you that underscores need to be replaced with slashes, while you put it into PHP/Debug/Renderer/HTML_Div_Config.php - If you use visiblity modifiers (public, protected, private), use them everywhere - "@since 30 march 2007" normally tells you which version, not which date Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=260 -- Sent by PEPr, the automatic proposal system at http://pear.php.net ___________________________________________________________________________ Découvrez une nouvelle façon d'obtenir des réponses à toutes vos questions ! Profitez des connaissances, des opinions et des expériences des internautes sur Yahoo! Questions/Réponses http://fr.answers.yahoo.com