Re: Regarding HTTP_Request bug #10790
| From: | Alexey Borzov | Date: | Wed, 02 May 2007 07:14:50 +0000 |
| Subject: | Re: Regarding HTTP_Request bug #10790 | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-46540@lists.php.net to get a copy of this message | ||
Hi,
Bill Moran wrote:
I was wondering what the status on this is. It's biting us right now and I'd like to see a fix go through the proper channels, as opposed to hacking it locally. According to http://bugs.php.net/bug.php?id=39062 the following diff should ensure that this bug is squashed, even if the PHP folks decide to change the behaviour of crc32() again: 1374c1374Have you tested the fix in question? I don't have a 64-bit box around, so will have to rely on someone else testing it. And yes, I'm going to do a bugfix release sometime soon, but will need to fix #10605 also and revisit the gzip vs. mb_*() changes done sometime ago.< if ($crcReal != $crcStored[1]) {---1390c1390if (dechex($crcReal) != dechex($crcStored[1])) {< } elseif ($dataCrc != crc32($unpacked)) {---} elseif (dechex($dataCrc) != dechex(crc32($unpacked))) {