[PEPr] +1 for Internationalization::I18N_UnicodeNormalizer

From: Date: Wed, 20 Jun 2007 19:15:34 +0000
Subject: [PEPr] +1 for Internationalization::I18N_UnicodeNormalizer
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-47083@lists.php.net to get a copy of this message
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for Internationalization::I18N_UnicodeNormalizer. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=494 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=494&handle=justinpatrin This vote is conditional. The condition is: Comments should be before the line they are for. Having them after the line makes the code even more dense than it needs to be and harder to read. Conditional code should not use "or" in a normal line of code. It makes the code generally harder to understand. Please use a standard if statement instead of e.g.: self::$combining or self::$combining = require($this->compiled['combining']); Is there a particular reason you're using self:: instead of $this->? || and && are more generally used than "or" and "and" when writing conditionals. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#47083) next »