Re: [PEPr] +1 for Encryption::Crypt_DiffieHellman

Thanks for the votes, all. I seem to have committed a few errors with the last batch of changes which I'm looking into - seeing as my working copy is working it's looking like I did something silly like not completely syncing all changes to subversion. Let the shin kicking commence ;). I'll run the last batch through subversion during tomorrow when I'm back at my Linux comp - just spending the evening here letting Vista loose on my PC and hoping it doesn't break anything! Paddy Pádraic Brady http://blog.astrumfutura.com http://www.patternsforphp.com ----- Original Message ---- From: Adam Harvey <aharvey@php.net> To: PEAR developer mailinglist <pear-dev@lists.php.net> Cc: Adam Harvey <aharvey@php.net>; Pádraic Brady <padraic.brady@yahoo.com> Sent: Monday, July 2, 2007 6:54:47 PM Subject: [PEAR-DEV] [PEPr] +1 for Encryption::Crypt_DiffieHellman Adam Harvey (http://pear.php.net/user/aharvey) has voted +1 on the proposal for Encryption::Crypt_DiffieHellman. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=496 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=496&handle=aharvey This vote is conditional. The condition is: I don't have the cryptographic background to assess the implementation of the algorithm itself, but I did run the unit tests. I'm +1 assuming a couple of minor issues I ran across while testing are fixed: - Line 380 of DiffieHellman.php refers to Crypt_DiffieHellman_BigInteger and not Crypt_DiffieHellman_Math_BigInteger, which I presume it should. - The Crypt_DiffieHellmanTest test fails at present due to $aliceSecretKey and $bobSecretKey being instances of Crypt_DiffieHellman. Appending a call to getSharedSecretKey() in lines 29 and 30 of tests/DiffieHellmanTest.php seems to deal with that. Beyond that, I'd wonder if the Math classes could be split off into a separate package (Math_BigInteger2?), since they're generally applicable, but my vote's not conditional on that happening. -- Sent by PEPr, the automatic proposal system at http://pear.php.net -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php ____________________________________________________________________________________ Don't pick lemons. See all the new 2007 cars at Yahoo! Autos. http://autos.yahoo.com/new_cars.html