[PEPr] Comment on Mail::Mail_Admin

Till Klampaeckel (http://pear.php.net/user/till) has commented on the proposal for Mail::Mail_Admin. Comment: I like the idea to provide a unified API to numerous mailservers/installations. (But I just have no idea how to test this since my postfix setup is pretty different. ;)) Is your driver based on some opensource project (e.g. postfixadmin or pmwh(2))? Some things I noticed: 1) Sometimes you just throw a regular "Exception". 2) I think your Exceptions should be "stacked", e.g. all come from Mail_Admin_Exception() to allow catching *all* exceptions which related to your package in a single catch. 3) Sometimes you echo errors inside the class. 4) Also, would driver and base class be seperated? 5) MDB2 should be an optional dep since not all drivers will use a DB. 6) The one class per file rule, or did that get dropped? P.S. Linking directly to your code would be a huge plus, since your WebSVN is pretty "crowed". ;) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=504 -- Sent by PEPr, the automatic proposal system at http://pear.php.net