Re: PEAR2 Coding Standards RFC

Alexey Borzov wrote: > Hi, > > Gregory Beaver wrote: >> I have made the requested changes to the PEAR2 Coding Standards RFC at >> http://wiki.pear.php.net/index.php/PEAR2_Standards. >> >> * controversial items split out >> * adjustments based on mailing list conversations >> >> I have moved controversial things to >> http://wiki.pear.php.net/index.php/Controversial_Changes > > Thanks, that looks a lot better now. > >> It should be noted that early assertions by Alan about the lack of >> performance benefit from removing require_once have been disputed by >> Gopal, who has found up to 10% performance improvement in his work at >> Yahoo!. The performance benefit of removing require_once for advanced >> users can be significant. Most users, however, will not see more than >> 2% improvement. > > I suggest dropping the "performance" argument, as the fastest way is > of course putting everything in one huge file, and we get the obvious > question "why don't we distribute our packages this way instead?" The point here is also that combining into a single file is possible without code modification for more packages if require_once is eliminated, but one must remember that multiple files also means we preserve line number information, which is much better for debugging. The tradeoff between maintainability and performance is balanced in this way. So yes, performance is still an argument even for separate files. Greg