Re: Re: Request to be added to PHP_LexerGenerator (and probably PHP_ParserGenerator)

Hi Alan, Tests can be phpt or PHPUnit as far as I know. I believe there was work being done to allow for PHPUnit tests across all packages be included in a PEAR wide test suite too. Paddy Pádraic Brady http://blog.astrumfutura.com http://www.patternsforphp.com OpenID Europe Foundation Member-Subscriber ----- Original Message ---- From: Alan Langford <jal@ambitonline.com> To: pear-dev@lists.php.net; Greg Beaver <greg@chiaraquartet.net> Cc: PEAR developer mailinglist <pear-dev@lists.php.net> Sent: Friday, September 21, 2007 11:55:23 AM Subject: [PEAR-DEV] Re: Request to be added to PHP_LexerGenerator (and probably PHP_ParserGenerator) On 2007 09 20 23:39, Greg Beaver wrote: > Alan Langford wrote: >> I have found and fixed a bug in this package, and another person has >> attached a few promising patches to bugs. >> >> I have also added processing instructions to flag regular expressions >> with the case-insensitive and Unicode flags. This makes case-less >> languages such as SQL much easier to handle. >> >> I'd like to get all of these changes (if the patches look good) into the >> trunk. > > Hi Alan, > > Sounds good to me, please ask PEAR Group for karma to > pear/PHP_LexerGenerator. I only ask that if your patch is at all > complex, please open a bug report prior to committing so that I can > review it. Small patches, such as many of the reports by joror, can be > committed without review if you verify they work. > > I would love to have help with writing tests for the package, and if you > feel up to the challenge, please take that on as well. > > Thanks, > Greg I have merged all the changes into my local copy and made some changes to juror's code (one bug fix and some coding standards compliance edits). The changes still need testing, which is an invitation to start writing test cases. I spent some time last night looking for guidelines and/or documentation on the testing environment without success, can someone point me at information on what's required? I know I've seen this somewhere. Specifically, can I assume that there's an up-to-date version of PHPUnit available? I have a testing assignment in another project that uses this package; it would be good to be able to use the same tools in both places. I might even get to the point where I think I know what I'm doing. Ha. -- PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php ____________________________________________________________________________________ Check out the hottest 2008 models today at Yahoo! Autos. http://autos.yahoo.com/new_cars.html