Re: Making old PEAR packages (more) E_STRICT compatible

From: Date: Mon, 24 Sep 2007 19:15:21 +0000
Subject: Re: Making old PEAR packages (more) E_STRICT compatible
References: 1 2  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-48166@lists.php.net to get a copy of this message
Alexey Borzov wrote:
I think that's quite simple: if you want to run under E_STRICT then don't use PHP4 code. If you want to use PHP4 code then don't run under E_STRICT. Well, currently I do use PHP4 code and run with E_STRICT, and it works without problems except for two lines in PEAR.php and one in the DB package (and until recently a few lines in the Net_SMTP and Mail packages) that I change manually upon every new release.
This works for me. My reason for suggesting it to the list was to make it easier for other people to use PHP4 packages and E_STRICT warnings. Abandoning PHP4 code is not an option for me, since most of the packages I use are only available in a PHP4 version. I could of course turn off E_STRICT warnings, but I find them helpful and I would rather manually fix the few problems in the source code of released packages rather do without them. I assume at least some users would prefer having E_STRICT warnings turned on if possible.
Did you consult Xcache developers? Did you submit a bug report for it? I submitted a bug about a related issue in eAccelerator a while back. This was WONTFIXed:
https://sourceforge.net/tracker/?func=detail&atid=692864&aid=1200738&group_id=122249 I have not submitted a bug for Xcache, though. But that is probably a good idea. I'll do that later. A reason for bringing this up on the mailinglist was to hear other people's experiences with other opcode caches. If the problem can be avoided without changing PEAR, that is probably preferable.
Why your first impulse is to "fix" PEAR for your corner case, probably breaking it for some other people? After having talked to the package owners of Net_SMTP and DB about this, and they both agreed to make changes to their packages, I raised it as a proposal on this mailinglist a few days ago and asked for people's thoughts.
I do by no means suggest breaking BC or anything else for anybody. If people oppose to the idea, I wont push it further. As mentioned, I have solved my own problem. Christian

« previous php.pear.dev (#48166) next »