global variables in php4 code
| From: | Lukas Kahwe Smith | Date: | Mon, 08 Oct 2007 12:41:26 +0000 |
| Subject: | global variables in php4 code | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-48235@lists.php.net to get a copy of this message | ||
Hi,
hmm .. i am just looking at:
http://cvs.php.net/viewvc.cgi/pear/Text_Password/Password.php?view=annotate
that global $_Text_Password_NumberOfPossibleCharacters var definition seems incorrect to me. it should use $GLOBALS explicitly as otherwise it might cause issues if included inside a function. thoughts? i only wanted to look at the implementation, i did not really try out the code.
regards,
Lukas