Re: CS question: do private function namechanges count as API changes?

On Nov 16, 2007 12:36 PM, Jorrit Schippers <jorrit@ncode.nl> wrote: > I've read that API changes are not recommended, but do private method > changes count as API methods? And should I change it to determineOSMatch(), > _determineOSMatch() or perhaps (_)determineOsMatch()? > My gut reaction would be private *anything* is fair game, as by definition anything *private* is not part of a library's "API". However, others that have been in PEAR longer than me should definitely confirm this, as I'd bet the question has come up and been discussed before. > Besides that, what would be the correct way of keeping line 572 [1] within > the required 85 character / line limit? It's a variable defined in the > class, so tricks like splitting the string do not help. > Wow, what a string :P I'd split it into pieces that are all dot-concatenated together, at a minimum like this; 'pattern' => '/(?:(d)|.)([rwxt-]+)\s+(\w+)\s+([\w\d-]+)\s+([\w\d-]+)*'* *. '*\s+(\w+)\s+(\S+\s+\S+\s+\S+)\s+(.+)/', -- CRB Let me introduce you to my very own DMCA-protected encryption key: BC 1B 64 4A 8D DE 49 E8 C3 7D CC EE 1A AD EE F5 (compliments of Freedom-to-Tinker http://www.freedom-to-tinker.com/?p=1155)