Services_W3C_CSSValidator 0.2.0 accordingly to user-end votes comment
| From: | Laurent Laville | Date: | Wed, 21 Nov 2007 20:18:13 +0000 |
| Subject: | Services_W3C_CSSValidator 0.2.0 accordingly to user-end votes comment | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-48566@lists.php.net to get a copy of this message | ||
Hi all,
And especially to those who have voted for my proposal [1]
I've worked on your comments, and now I'm ready to propose you the new version Services_W3C_CSSValidator-0.2.0 [2], with :
- Christian Weiske : @since and @access phpdoc tags (removed)
- Till Klampaeckel : add a bit of setters and getters
- David Coallier : add a bit of setters and getters instead of only
using setOptions
Class properties are now protected rather than public
addError() and addWarning() methods added into
Services_W3C_CSSValidator_Response
I've also fixed some coding standard with help of PHP_CodeSniffer, even on my test suite, exception (of course) for
FILE: C:\pearix-dev\pepr\Services_W3C_CSSValidator\tests\AllTests.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 0 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
17 | ERROR | Constants must be uppercase; expected 'PHPUNIT_MAIN_METHOD' but
| | found 'PHPUnit_MAIN_METHOD'68 | ERROR | Constants must be uppercase; expected PHPUNIT_MAIN_METHOD but
| | found PHPUnit_MAIN_METHOD-------------------------------------------------------------------------------- FILE: ...\pepr\Services_W3C_CSSValidator\tests\Services_W3C_CSSValidatorTest.php -------------------------------------------------------------------------------- FOUND 2 ERROR(S) AND 0 WARNING(S) AFFECTING 2 LINE(S) -------------------------------------------------------------------------------- 16 | ERROR | Constants must be uppercase; expected "PHPUNIT_MAIN_METHOD" but
| | found "PHPUnit_MAIN_METHOD"
146 | ERROR | Constants must be uppercase; expected PHPUNIT_MAIN_METHOD but
| | found PHPUnit_MAIN_METHOD
--------------------------------------------------------------------------------
I hope this adjustement will be what you have expected for
If everyone is ok, and of course QA group, I can then publish it as first PEAR public version.
Regards
Laurent Laville
[1] http://pear.php.net/pepr/pepr-proposal-show.php?id=510
[2] http://pear.laurent-laville.org/pepr/Services_W3C_CSSValidator/Services_W3C_CSSValidator-0.2.0.tgz