PHP_CodeSniffer and constant alignement
| From: | Laurent Laville | Date: | Sun, 25 Nov 2007 14:57:17 +0000 |
| Subject: | PHP_CodeSniffer and constant alignement | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-48583@lists.php.net to get a copy of this message | ||
Hi all,
As I don't know if subject was already talked to, I ask (perharps again) if Coding Standard for constant alignement is suppose to be (for example)
32: // Constants for preferences.
33: define('PEAR_PACKAGEUPDATE_PREF_NOUPDATES', 0);
34: define('PEAR_PACKAGEUPDATE_PREF_NEXTRELEASE', 1);
35: define('PEAR_PACKAGEUPDATE_PREF_TYPE', 2);
36: define('PEAR_PACKAGEUPDATE_PREF_STATE', 3);
Or just , as suggested by PHP_CodeSniffer (1.0.0RC2) :
33 | ERROR | Expected 1 space after comma in function call; 3 found
35 | ERROR | Expected 1 space after comma in function call; 8 found
36 | ERROR | Expected 1 space after comma in function call; 7 found
32: // Constants for preferences.
33: define('PEAR_PACKAGEUPDATE_PREF_NOUPDATES', 0);
34: define('PEAR_PACKAGEUPDATE_PREF_NEXTRELEASE', 1);
35: define('PEAR_PACKAGEUPDATE_PREF_TYPE', 2);
36: define('PEAR_PACKAGEUPDATE_PREF_STATE', 3);
Thanks in advance
Laurent