Re: Re: Problem creating an acount to submit a proposal

On Dec 31, 2007 6:38 AM, Mark Wiesemann <wiesemann@php.net> wrote: > Hi, > > Bakir Hassani wrote: > > I have a draft for a new template engine: > > http://simplewebcode.com/oop/oop_template.php > > but when I try to create an acount on Pear I get this error message: > > 'ERROR: > > a.. The purpose(s) you selected do not require a PEAR account. > > b.. Incorrect CAPTCHA' > > I checked 'Propose a new, incomplete package, or an incomplete idea for a > > package' > > anyone have an idea about this error? > > Please read the whole page. On top you can find this sentence: > | You have chosen to request an account for proposing a new (and *complete*) > | package for inclusion in PEAR. > > Do you notice a difference between the text behind the checkbox and this > sentence? ;-) > > The second error message is related to the "Solve the problem:" field. > > Regards, > Mark > > -- > http://www.markwiesemann.eu > > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > Few points you have to fix. 1. Make that php5 2. Use proper naming (Prefix with PEAR_ your class name) 3. Read the coding standards 4. Add more benchmark, from looking at that code it doesn't seem faster than what's out there. Do we really need another templating engine ? Have you looked at Sigma, Flexy, PHPLIB, Xipe ? Can you put benchmark up there 5. Variables by references (in function declaration) are deprecated. 6. What's OOP_Template ? I see basically no OO, I'd suggest changing the whole name. 7. require_once doesn't require you to use () 8. Cache ? Hrm... 9. New packages HAVE to make use of PEAR_Exception. At least you should be using PEAR_Error for your own good. 10. class block simply doesn't make sense and is not acceptable for any wide spread and large open source project. This naming will mostly conflict with some 3rd party package. A lot of things are missing and I am not sure you can really *upgrade* from IT to OOP_Template. Looking at the code there's an important feature missing that is glob variables. Why don't you simply contact the people of Template_IT and send them some patches to reorganize and optimize the code ? That'd be much cleaner. In other words, good luck and I hope those points will help you grow up in your package development :) -- David Coallier, Founder & Software Architect, Agora Production (http://agoraproduction.com) 51.42.06.70.18