[PEPr] Comment on Encryption::HCE_SHA

From: Date: Wed, 09 Jan 2008 22:11:56 +0000
Subject: [PEPr] Comment on Encryption::HCE_SHA
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-48909@lists.php.net to get a copy of this message
Chuck Burgess (http://pear.php.net/user/ashnazg) has commented on the proposal for Encryption::HCE_SHA. Comment: Coding standard concerns seem to be covered already. I also agree that I'd expect this kind of class to be in the Crypt hierarchy. The only thing that jumped out at me is how much hce_block_encrypt() and hce_block_decrypt() look like they're about 95% identical. I don't think I could avoid the temptation of refactoring all that common code into private method that both of those two public methods would utilize. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=464 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#48909) next »