[PEPr] +1 for File Formats::File_XSN
| From: | Philippe Jausions | Date: | Tue, 05 Feb 2008 16:53:51 +0000 |
| Subject: | [PEPr] +1 for File Formats::File_XSN | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49085@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has voted +1 on the proposal for File
Formats::File_XSN.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=526
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=526&handle=jausions
This vote is conditional. The condition is:
Overall pretty good.
Just some conditions based on some of my previous comments:
- "$instruction = $template->createProcessingInstruction('php', "echo
$this->form['{$field_name}']['html']?");" should be made hack-proof
by escaping single quotes ' in $field_name to prevent PHP code injection.
- Spinning the templateConvert() method into a factorized template converter class doesn't
take long to do and should already stabilize the API (even though still alpha) Not strictly
essential, but will allow other contributors to write other template converter more easily.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net