[PEPr] +1 for PEAR::PEAR_Size

From: Date: Mon, 03 Mar 2008 21:22:29 +0000
Subject: [PEPr] +1 for PEAR::PEAR_Size
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-49251@lists.php.net to get a copy of this message
David Jean Louis (http://pear.php.net/user/izi) has voted +1 on the proposal for PEAR::PEAR_Size. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=522 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=522&handle=izi Comment: I also get the notices reported by Christian. Some notes: - I don't like very much these setters that just assign the value to a public var (setVerbose, setHumanReadable...etc), they are quite useless imho; - you should declare these public class variables at class level (eg. public $verbose = false;); - imho HTML_Table and Console_Table should be optional requirements (if Console_Table is installed use it and if not the result is tableless). Otherwise nice package. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#49251) next »