Re: Pyrus patch

Hey On Fri, Feb 22, 2008 at 5:41 PM, Brett Bieber <brett.bieber@gmail.com> wrote: > Ehh... seeing no PEAR2 ML I guess I'll send these over here. I have a > patch for Pyrus -- and no karma! (probably best we keep it that way) Hmm... anyone have some thoughts on where stuff like this needs to go? --- anyways - here's another patch. The extract function needs to close the files it opens, otherwise we end up with: "failed to open stream: Too many open files" You get this error when you try to run a script which extracts all the tgz files from pear download-all, for example. and come on people, start playing with Pyrus.. it's way cool. :-) -- Brett Bieber http://saltybeagle.com/

Index: /home/bbieber/workspace/Pyrus/src/Pyrus/Package/Tar.php =================================================================== --- /home/bbieber/workspace/Pyrus/src/Pyrus/Package/Tar.php (revision 291) +++ /home/bbieber/workspace/Pyrus/src/Pyrus/Package/Tar.php (working copy) @@ -303,6 +303,8 @@ } } } while ($this->_internalFileLength); + fclose($fp); + fclose($this->_fp); if (!$packagexml) { throw new PEAR2_Pyrus_Package_Tar_Exception('Archive ' . $this->_packagename . ' does not contain a package.xml file');