[PEPr] Comment on Web Services::Services_Yahoo_JP
| From: | Ken Guest | Date: | Tue, 25 Mar 2008 14:51:38 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_Yahoo_JP | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49545@lists.php.net to get a copy of this message | ||
Ken Guest (http://pear.php.net/user/kguest) has commented on the proposal for Web
Services::Services_Yahoo_JP.
Comment:
I downloaded the .tgz of the package and ran phpcs on the code to see how
compliant it is with the PEAR Coding Standards - it found a total of 627
errors and 20 warnings :(
If your code is for PHP 5 only you don't need to use @access tags in your
phpdoc headers and you really should have documentation in place for class
level variables.
Other than that it seems like good clean code.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=545
--
Sent by PEPr, the automatic proposal system at http://pear.php.net