Re: phpcs throwing warnings on trivial things

On Sat, Apr 5, 2008 at 11:35 AM, till <klimpong@gmail.com> wrote: > On Sat, Apr 5, 2008 at 7:21 AM, Joe Stump <joe@joestump.net> wrote: > > (...) > > This phpcs stuff is 98% nonsense. I hope we're not actively keeping > > packages OUT of PEAR due to whether or not a package has 2 or 4 spaces > after > > the @category tag. At least the package is documented. Bureaucracy gone > wild > > if you ask me. > > > > If anyone needs me I'll be fixing 600+ trivial nonsensical "errors" in > my > > code for Services_Facebook. > > I agree that this is a pain in the buttocks to fix them. And I > wouldn't necessarily deny a package in PEAR just because of CS, but > where would you draw the line? Like, you are saying "2 or 4 spaces is > not a show-stopper", next person says, "but my method names are so > obvious, I don't need to document them" (just an example). > > I totally feel you when you say it's non-sense because correcting them > is a lot of work and so on, but then again, a standard is a standard. > There is no 90% standard compliant, or 80%. There is just 100%. > > If you want, I can help you fix the 600 over the weekend. :-) Joe I thought that was a warning not an error ? :o If it's not then phpcs is broken IMHO This is the reason why I always liked the human CS checking approach ;-) It's more laxed and more to the point of what actually requires changing :-) Don't beat ya self up about this Joe, commit, be happy, fix them over time (and do not focus on that docblock CS bullocks, the spaces part of similar trivial thing) - Helgi