[PEPr] Comment on Database::SimpleDAO
| From: | Travis Swicegood | Date: | Sun, 06 Apr 2008 00:46:15 +0000 |
| Subject: | [PEPr] Comment on Database::SimpleDAO | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49652@lists.php.net to get a copy of this message | ||
Travis Swicegood (http://pear.php.net/user/tswicegood) has commented on the proposal for
Database::SimpleDAO.
Comment:
Hi;
I've given this package a quick review. Here's a few quick points:
* I'm not sure I understand the need this is filling that isn't already
covered by MDB2 and its related packages. Could you explain it better?
* You'll need to revisit the PEAR Coding Standard (see the PEAR manual for
more info) before this is ready for a vote. In particular, it is lacking
in proper documentation and class naming.
I would encourage you to discuss this via the pear-dev mailing list. I'm
sure someone there would be willing to help mentor you through the process
to give this package the best chance of success. As it stands right now,
however, the two outstanding issues I've mentioned are possible blockers
for its inclusion.
Please make sure to explain what role this package fills that isn't
already filled and make sure it's at least close to the expected formatting
standard.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=547
--
Sent by PEPr, the automatic proposal system at http://pear.php.net