[PEPr] +1 for Web Services::Services_TwitPic
| From: | Michael Gauthier | Date: | Mon, 08 Sep 2008 15:43:50 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_TwitPic | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50721@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for Web
Services::Services_TwitPic.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=568
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=568&handle=gauthierm
Comment:
Nice clean and simple code.
1.) there's a typo 'endpoing' in Services_TwitPic_Request_Common
2.) documentation should not restate the method/class name
3.) method documentation should use 3rd person declarative rather than 2nd
person imperative ('Sets foo' rather than 'Set foo'). See
http://pear.php.net/manual/en/standards.sample.php
4.) more specific exception types would be useful
5.) I think you can turn off errors in simplexml using
libxml_use_internal_errors(). You can then manually handle the errors using
libxml_get_errors(). You're right the SimpleXML documentation is lacking
this information.
6.) available options are not documented. I recommend adding this to
either the class documentation or the setOptions() documentation.
7.) a setOption() method that sets a single option might be handy. It
could be used inside setOptions()
--
Sent by PEPr, the automatic proposal system at http://pear.php.net