[PEPr] -1 for Database::MDB2_TableBrowser
| From: | David Coallier | Date: | Fri, 12 Sep 2008 09:49:18 +0000 |
| Subject: | [PEPr] -1 for Database::MDB2_TableBrowser | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50750@lists.php.net to get a copy of this message | ||
David Coallier (http://pear.php.net/user/davidc) has voted -1 on the proposal for
Database::MDB2_TableBrowser.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=570
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=570&handle=davidc
Comment:
- Lack of architectural and modularity. A 400 lines long class is simply
too long
- SQL Specific (LIMIT for instance)
- Coding standards are not PEAR compliant but this is something I had
already told you. It's always possible to fix.
- Great work but the overall quality is not up to a PEAR standard in my
opinion (not yet).
Thanks,
--
Sent by PEPr, the automatic proposal system at http://pear.php.net