[PEPr] Comment on Images::Image_Barcode2

From: Date: Mon, 29 Dec 2008 13:37:02 +0000
Subject: [PEPr] Comment on Images::Image_Barcode2
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-51360@lists.php.net to get a copy of this message
David Jean Louis (http://pear.php.net/user/izi) has commented on the proposal for Images::Image_Barcode2. Comment: Hi Dave, Very good initiative. All tests pass and phpcs is silent on the the "Image" directory. Just a minor note: * The test files contain tabs instead of spaces (probably inherited from the old code)... you should "s/\t/ /" them; * You should remove the closing php tag (?>), it's not needed and as it's an image package it will prevent breaking image generation if there's extra space after the closing tag. -- David Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=584 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#51360) next »