Re: Log::XML - Request for Comments, preparing the package for a vote

Hello Michael, > It's been a while since I've worked on this package (some may recall > it from last summer) but I went over the code again, added in some > more defensive code and verified that it works on Ubuntu. You should go through the docblock comments and verify they are correct - I saw some Log_file references that probably were copied from the other log implementation. Also, remove @access tags - they partly contradict the php5 visibility modifier, and are not needed. Please also remove that "$projectRoot" stuff from your logging implementations. All it does can be solved by setting up a proper include path. Another question for me would be: How does Log_XML handle millions of log entries? I saw that you use a DOM object and store all log messages in it, saving it into a file at the end. This will fail if there is not much memory available and/or really much data get logged. A better approach - IMO would be to write the XML head at first (without closing tag) and each log message - as an xml document - separately - without the xml header of course. When closing, the finishing XML tag is written. I did this when exporting some 1.5GiB of product data out of a shop database into an xml file. I think it's a bad base if you expect all log_xml drivers to use DOM - that does not work. -- Regards/Mit freundlichen Grüßen Christian Weiske -= Geeking around in the name of science since 1982 =-

Attachment: [application/pgp-signature] signature.asc