Re: Crypt_DiffieHellman dependencies

On Jun 25, 2009, at 2:28 PM, Thomas Anderson wrote:

http://pear.php.net/package/Crypt_DiffieHellman/download According to that, the only PHP Extension required is mbstring. Shouldn't 'bcmath or gmp' be listed as dependencies, as well?:

Indeed.

http://cvs.php.net/viewvc.cgi/pear/Crypt_DiffieHellman/DiffieHellman/Math/BigInteger/ Also, it seems strange that Crypt_DiffieHellman would have its own implementation of Math_BigInteger when there's already a Math_BigInteger class in PEAR: http://pear.php.net/package/Math_BigInteger/

Interesting. I was not aware of it (I'm not the author of the package either, though). I can look into updating Crypt_DiffieHellman to use it. It has some other functionality that OpenID can use too.

Using Crypt_DiffieHellman as precedent, the soon to be proposed OpenID library should have its own Crypt_DiffieHellman implementation, ignoring the existing implementation,

I disagree. The Diffie-Hellman protocol is not specific to OpenID. It's a 30 year old protocol that has lots of other use cases. It should be its own package. Besides, not all OpenID implementations use it, they pass the association mac key over SSL instead.

Besides, using Math_BigInteger would eliminate the need to state 'bcmath or gmp' as dependencies.

Indeed. Cheers, Bill