[PEPr] Changes in proposal for XML::Create_KML
| From: | Robert McLeod | Date: | Sat, 17 Oct 2009 06:34:32 +0000 |
| Subject: | [PEPr] Changes in proposal for XML::Create_KML | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-52953@lists.php.net to get a copy of this message | ||
Robert McLeod (http://pear.php.net/user/hamstar) has edited the proposal for XML::Create_KML.
Change comment:
Various fixes and changes as suggested from the comments on proposal.
* The function to create the KML code now uses the SimpleXML class.
* Function to create KML code is now in the magic __toString() method
under the XML_KML_Create
* Removed the save() method
* Implemented constructers and destructers
* Implemented one-class-per-file rule adding Main.php KML/Place.php and
KML/Style.php
* Changed class name KML to XML_KML_Create
* Changed class name KMLPlace to XML_KML_Place
* Changed class name KMLStyle to XML_KML_Style
* Implemented set*() methods on XML_KML_Style and XML_KML_Place that
validate input
* Code now adheres to PHPCodeSniffer standards
Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=616