[PEPr] Comment on Internationalization::Arabic
| From: | David Coallier | Date: | Wed, 04 Nov 2009 18:21:32 +0000 |
| Subject: | [PEPr] Comment on Internationalization::Arabic | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53022@lists.php.net to get a copy of this message | ||
I am definitely for refactoring, in fact I will not vote +1 on this if it
isn't. It is a great package but it has to comply and refactoring is not
only for the sake of refactoring.
@Mohamed The idea behind making the code more decoupled is because it is
easier to distribute (say you want to use only "x" part of the arabic
package, you don't need the whole package, only part "x") and obviously the
quality of each package can be maintained in a much more controlled way. By
having a variety of independent packages, you can insure better unit
testing of each package and that is a great asset.
What I would suggest is that you try to identify all the parts that are
independent to one another and see which is the real core, and how all the
pieces are stuck together.
This means you'll have one main package which will depend on all the
smaller packages however the smaller packages will NOT depend on the bigger
ones thus making them independent.
If you need help on how to refactor your code I would highly suggest
sending an email to the pear-dev mailing list to request comments on how to
do it.
On another note, the name "Arabic" does not fit a category name. It is
Arabic in the Internationalization category (i18n). So something like
I18N_Arabic makes much more sense and I'd be surprised to see "Arabic_*"
accepted :)
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=617