Re: method for Crypt_GPG to sign and encrypt file in one pass
| From: | Michael Gauthier | Date: | Thu, 12 Nov 2009 15:38:03 +0000 |
| Subject: | Re: method for Crypt_GPG to sign and encrypt file in one pass | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53043@lists.php.net to get a copy of this message | ||
On Thu, 2009-11-12 at 12:32 +0000, Ken Guest wrote:
> hi Mike,
> patch attached for signing and encrypting a file in one pass with
> Crypt_GPG - something that's required here immediately so I
> went ahead and added it to a local install of the package. Didn't
> really have the time to file a feature request or anything like that.
>
> Thought you might want to look over it and perhaps incorporate it into
> the public version of Crypt_GPG.
>
>
Ken,
I cleaned up and applied your patch in changeset 290586. See:
http://svn.php.net/viewvc/pear/packages/Crypt_GPG/trunk/Crypt/GPG.php?r1=290586&r2=290585&pathrev=290586&diff_format=u
The biggest change I made was the method name. I chose encryptAndSign()
instead of signAndEncrypt() because it matches the GnuPG APIs of other
languages better.
The change will be in the next public release of Crypt_GPG, which will
happen after I write new tests for the new features in trunk.
Regards,
Mike