[PEPr] Comment on Math::Math_Assoc
| From: | Philippe Jausions | Date: | Wed, 02 Dec 2009 19:17:09 +0000 |
| Subject: | [PEPr] Comment on Math::Math_Assoc | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53081@lists.php.net to get a copy of this message | ||
Couple of comments.
- Avoid using the PHP license. MIT, LGPL, New BSD etc are preferred ones
- The existing Number_Roman package already handles the Roman to Arabic
conversion
- Package should be PHP 5+
- Put the code of your package directly viewable online
- Use func_get_args() to eliminate duplicate functions gcm(), gcm_mult()
and so forth
- function names should be camelCase isPositive() vs is_positive()
I don't know what your date and conversion functions do, but they
shouldn't be in the same package as an equation-related one.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=619