[PEPr] +1 for Images::Image_QRCode

From: Date: Fri, 25 Dec 2009 20:04:37 +0000
Subject: [PEPr] +1 for Images::Image_QRCode
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-53153@lists.php.net to get a copy of this message
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Images::Image_QRCode. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=623 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=623&handle=till This vote is conditional. The condition is: Hey Rich, I briefly looked and here are my suggestions which make this vote conditional: - Image_QRCode::makeCode() needs heavy refactoring - @access tags are redundant - all your set*() methods in (Image_QRCode) could be public and "return $this;" (to provide a fluent interface) - "data" and "image" directories should be on the top level like "doc" (but anyway, kudos for a complete package.xml) - your API version is to high - unit tests that cover the current feature set are needed I look forward to this code in PEAR! Happy holidays, Till

« previous php.pear.dev (#53153) next »