Re: Image_QRCode package

On Tue, 2009-12-29 at 14:08 +0000, Rich Sage wrote: > Hi all, > > Re. Image_QRCode package proposal - the vote result indicated the package > was accepted, but I'm aware that there were a couple of conditional votes > based on adding tests and some refactoring. I've now added some tests and > refactored the main method in the class, but I'd like to get "approval" from > pear-dev before I proceed with the process of adding the package to PEAR. > > The code, as per the original proposal, is at > http://code.google.com/p/pearqrcode - I'd be grateful if > any of you had some > time to just review this before I continue! > Hi Rich, Sorry I didn't have time to review the code earlier during the vote. I've had a look over your revised version and it looks good to me. You've addressed pretty much all of the conditions requested by Till and Bill. Changing the set*() methods to return $this as suggested by Till would still be nice, but for now I'd say go ahead and create the proper PEAR package. You've certainly shown that you considered and understood the feedback during the voting process. Cheers, Mike