[PEPr] Comment on Web Services::Services_RackCloud
| From: | Brett Bieber | Date: | Tue, 18 May 2010 19:36:44 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_RackCloud | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53479@lists.php.net to get a copy of this message | ||
Woohoo. I think this package could be useful. Some initial thoughts -
I'd change the private methods to protected, unless you're really
certain.
As is, the curl extension should be added to the package.xml as a required
dependency, but I'd recommend using HTTP_Request2 for the communication
layer. Not everyone will have the curl extension enabled or available.
Second is the Exception. I know PEAR (1) tells you to extend
PEAR_Exception, but I'd be in favor of using the new PEAR2 exception
standards which don't require the additional dependency. As it is, you're
extending PEAR_Exception, which is in the PEAR package, but that is not
listed as a required dependency.
The example.php could go into a docs or examples dir, and bundled with the
package.
That's all the tips I have for now. I'm very interested in what others
think.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=630