Re: RE: [PEPr] Comment on Networking::Net_DNS2

On Thu, Aug 19, 2010 at 8:24 PM, Mike Pultz <mike@mrhost.ca> wrote: > Comments in-line > > > > Mike > > > >>1.) Use of the global __autoload() should not be part of this package. PEAR > >>packages should use something like "require_once 'Net/DNS/Header.php'" > > > > > > Yup- make sense- I think you could use autoload, but not __autoload(). ;-) Function __autoload() can only be used once in a codebase so you shouldn't hog it and keep the user from using it. :D But you could still write an autoloader and use SPL. E.g. make a method "public static Net_DNS2::autoload", and then use spl_autoload_register() to setup your autoloader. ;-) I think that's perfectly fine. SPL adds autoloaders to a chain that are executed so it shouldn't interfere with other code of the developer using your library. >>6.) Code that was adapted from Net::DNS PERL code needs to respect the same > >>license and should state the license in the file header. > > > > > > Yup- there's only a few RR's that I borrowed code directly from Net::DNS. If I remember correctly we even got everyone to agree to move Net_DNS from PHP license to BSD license. We just never got around to a release (shame on me). I can forward the thread about the license change per request. Till