Re: [PEPr] Comment on File Formats::PDF Reader

Hey John, Michael replied with all the necessities. :-) Let us know if you need help! Till On Sun, Aug 1, 2010 at 8:00 AM, FyreHeart <jstokes@heartofthefyre.us> wrote: > Thanks for commenting, Till. > > What issues do you see that I need to work on? I've already run it through > CodeSniffer and addressed most of the issues reported. (Notable exceptions > are line length and not removing indents from switch statements.) > > -John > > Till Klampaeckel wrote: >> >> Hey John, >> >> >> >> you'll obviously need to work on a few things in order to be accepted into >> PEAR, and I'd really welcome it if you do. :-) >> >> >> >> Most, if not all issues can be identified by running PHP_CodeSniffer >> against your code: >> >> http://pear.php.net/package/PHP_CodeSniffer >> >> >> >> pear install PHP_CodeSniffer >> >> phpcs /path/to/your/code/* >> >> >> >> Then - this is more an added bonus, but not less important: tests. :-) >> >> >> >> Let me know if you have any questions! >> >> >> >> Till >> >> > > -- > John Stokes > jstokes@heartofthefyre.us > http://heartofthefyre.us > > "Humility - Communication - Balance" > >