[PEPr] -1 for Nagios::Nagios_Plugin
| From: | Michael Gauthier | Date: | Tue, 11 Jan 2011 15:11:59 +0000 |
| Subject: | [PEPr] -1 for Nagios::Nagios_Plugin | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53968@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted -1 on the proposal for
Nagios::Nagios_Plugin.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=649
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=649&handle=gauthierm
Comment:
You should have asked for more comments on this proposal via the mailing
list before moving to the voting stage.
There are a number of coding standard violations that would prevent this
package from being accepted in PEAR, even if the package is well written.
Quickly:
1.) Use class constants, not define()
2.) Define scope of class properties (public/private/protected instead of
var)
3.) Class methods should use camelCase, not under_scores.
4.) ereg is deprecated in PHP, preg should be used instead.
5.) Line length should be no more than 85 chars.
6.) Documentation is required for each class property and method.
7.) Use of the PHP license is discouraged for PHP libraries. MIT, Apache or
BSD-style licenses are preferred.
You can quickly check your code against the PEAR coding standards using the
PHP_CodeSniffer tool.