[PEPr] Comment on Web Services::Services_OAuthUploader

From: Date: Fri, 25 Feb 2011 15:28:48 +0000
Subject: [PEPr] Comment on Web Services::Services_OAuthUploader
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-54112@lists.php.net to get a copy of this message
Hi, just commenting over here as well. I just send you a pull request: https://github.com/withgod/Services_OAuthUploader/pull/1 I personally think the code is fit for a release, there is one minor thing though. ;-) I think part of the mis-understanding what this class does is that it's not a generic OAuth uploader, but a class that allows uploading pictures to services which only allow people to login/signup using OAuth via Twitter. @Cweiske: That's also why the twitter constants are in the main class. All these services rely for authentication on Twitter, so that makes sense. I think namewise, I'd probably do something like, Services_Twitter_OAuthUploader - what do you guys think? Otherwise, while I think there's (always) room for improvement, the implementation is fit for a vote. Till -- http://pear.php.net/pepr/pepr-proposal-show.php?id=650

« previous php.pear.dev (#54112) next »