[PEPr] Comment on Web Services::AChecker
| From: | Till Klampaeckel | Date: | Sun, 27 Feb 2011 18:48:33 +0000 |
| Subject: | [PEPr] Comment on Web Services::AChecker | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54126@lists.php.net to get a copy of this message | ||
Code looks really clean - kudos for that. The documentation is great too!
In addition to what Christian said:
* I'd implement a fluent interface for all set (__set(), set*(), add*())
methods (currently you return void)
* I'd refactor parseRestResponse()
* in Services_AChecker_Response, Services_AChecker_Message, ...: I'd
rather have get and set methods instead of public variables (personal
preference, I guess)
* type hinting in addError(), addLikelyProblem(), addPotentialProblem()
* added bonus: unit tests :-)
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=655