Re: Re: New role=man for manpages :]

2011/6/10 Helgi Þormar Þorbjörnsson <helgith@gmail.com>: > On 30 Apr 2011, at 08:01, Daniel O'Connor wrote: > >> >> I am in the US and not much time for the next week to review patches. I'll get to it >> on one of my flights soon but please don't commit it to trunk until someone has given it thumbs >> up. New roles are tricky at times. >> >> Psst; helgi & other maintainers, with the understanding that Hannes will: >>  1. Fix the minor problems raised in this thread >>  2. Tested for possible bugs / edge cases (what happens on windows, testing for possible >> e_notices with weird arguments) >>  3. Document it >>  4. Have a crack at doing a patch for pyrus... >> >> Are you +1 / -1 to committing? > > I will probably commit it soon. I can't seem to find the patch and apparently Hannes had > an incident with his laptop and thus he lost his copy. > Can someone point me to it? I suppose he needs it as well if he is going to do any kind of > fixing. http://old.nabble.com/New-role%3Dman-for-manpages-%3A--p31422750.html Also the parse error Martin pointed out: > + $config->set('man_dir', $with_dir $ds . 'local' . $ds . > 'man', 'default'); ^^^^^^^^^^^^^ Parse error in here. -- Brett Bieber